Skip to content

feat(spec)!: retire connector.connectionTimeoutMs — carried everywhere, applied nowhere - #19657

Merged
os-justin merged 18 commits into
mainfrom
claude/issue-19580-retire-connector-connection-timeout
Sep 23, 2026
Merged

os-justin merged 18 commits into
mainfrom
claude/issue-19580-retire-connector-connection-timeout

Conversation

@os-warren

@os-warren os-warren commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Fixes #19580

Clause-②: yes (narrowing)

Ruled: comment 5770606746, batch #211 item 1, letter A — retire connector.connectionTimeoutMs (ADR-0049 enforce-or-remove; the standing 2026-09-10 「以协议为准」 ruling; the 2026-08-27 「no staged retirement」). Removal route: the spec-property-retirement playbook.

What this removes

A fully authorable key — bounded (min(1000).max(300000)), defaulted (30000), .describe()d, writable on ConnectorSchema and, through DeclarativeConnectorEntrySchema, on stack.connectors[] and PUT /meta/connector/:name, and served back by /meta/connector. Every signal an authoring surface can give said it worked. Plus the ConnectorProviderContext.connectionTimeoutMs member handed to every provider factory.

requestTimeoutMs is the replacement: the deadline the platform actually keeps, applied as resilientFetch's per-attempt timeout.

⭐ The measurement the ruling left to the dev — D2 or D3

The ruling prescribed a D3 semantic entry and said a D2 conversion is owed only if a stored connector row can carry the key — 「the dev measures」. It can, so both ship.

Measured first-hand on this branch, before the tombstone landed, against the built packages/spec/dist:

leg reading
getMetadataTypeSchema('connector') bound? true — it resolves DeclarativeConnectorEntrySchema, the shape PUT /api/v1/meta/connector/:name validates against
door parses a body carrying the key? true
does its output retain the authored value? 4321 — so the number reaches sys_metadata
control on the same instrument the already-retired sibling errorMapping on the same schema is refused — the door discriminates rather than accepting everything
applyConversionsToStoredItem('connector', row) live for this type? yes — it fired connector-error-mapping-removed and stripped that key from a stored row
control on the same seam the same row's requestTimeoutMs survived untouched, so the strip is attributable

What would have made it the other answer: getMetadataTypeSchema('connector') returning undefined (no write door ⇒ no stored row), or the door's output dropping the key, or the rehydration seam never reaching connector rows. All three fired the other way, so a D2 conversion is owed and a D3-only kit would have left 17.x rows carrying a key the schema now refuses.

Both dispositions are re-measured by pins in packages/spec/src/integration/connector-connection-timeout-retirement.test.ts, so the answer cannot rot into an assumption.

⚠️ The card is STALE, not wrong — and this section previously said otherwise

⛔ This section's earlier premise is known false and is replaced rather than patched. It claimed the card's Leg-2 table 「was already false when this retirement was taken」. It was not.

At the SHA the card cites and dates — 0870fb5418git grep -n connectionTimeoutMs SHA -- . ':!packages/spec' returns exactly five non-spec source hits, and all five are connectionTimeoutMs: 30000,: the card's table, line for line. ⇒ the card was correct when measured. What moved it is b929e0a662 (#19388) — the very PR the card itself flagged as pending.

At origin/main the same instrument returns thirteen non-test source occurrences over seven files in five packages: six reads, four type declarations, and three surviving pure hardcoded 30000 writes (connector-mcp/src/mcp-connector.ts, connector-slack/src/slack-connector.ts, service-automation/src/plugin.ts). ⚠️ Seven files, not five — five is the count of packages, and conflating the two is how the earlier number was reached.

site what it is
services/service-automation/src/plugin.ts:307 reads entry.connectionTimeoutMs into the materialization fingerprint
services/service-automation/src/plugin.ts:1589 reads it onto ConnectorProviderContext
connectors/connector-rest/src/rest-provider.ts:64 reads ctx.connectionTimeoutMs
connectors/connector-openapi/src/openapi-provider.ts:193 reads ctx.connectionTimeoutMs
connector-rest/src/rest-connector.ts:134, connector-openapi/src/openapi-connector.ts:242 ?? 30000 — read the opts and deposit the value on the reported def

The ruling's premise survives, and the mechanism is unchanged. Every read is a pass-through. The value's only termini are (a) the def GET /connectors echoes and (b) the fingerprint that decides whether to re-materialize. connectorFetchOptions() (integration/connector-fetch-policy.ts) is handed { retryConfig, requestTimeoutMs } only, and a pin has asserted since #18975 that nothing aliases this key onto timeoutMs. Carrying a number is not honouring it — the parsed-unmarked-unenforced state ADR-0049 forbids, wearing a longer route.

Nor was the 实现 arm available: a WHATWG fetch exposes one AbortSignal over the whole operation and never the connect phase, so bounding time-to-response with this key would kill a slow-but-connected upstream the author meant to allow with a large requestTimeoutMs.

Zero-enforcement verification, with its control

  • Claim: nothing applies the value as a deadline. Instrument: git grep -n connectionTimeoutMs over the whole worktree (45 hits, hand-read, not counted) plus the source of connectorFetchOptions(). Radius: the monorepo. Control: requestTimeoutMs — same schema, same census, same files — resolves to a real read (opts.timeoutMs = policy.requestTimeoutMs), so the instrument is not dead.
  • Pinned sibling checkout: git grep connectionTimeoutMs at objectui 87af769e9a3ee28ace099fdd653d3ebd79fe82e2 (the .objectui-sha pin) → exit 1, zero hits; control connector on the same command and scope returns 458 lines across 66 files; and requestTimeoutMs is exit 1 / 0 lines there, so it is not a usable control in that repo (it is in objectstack). ⇒ the Console Pin Gate needs no sibling fix and no pin bump with this removal.
    ⚠️ That clearance is about the sibling BUILD, and it is not the whole picture. The residue stage makes both carriers z.preprocess pipes, and objectui's packages/app-shell/src/views/metadata-admin/clientValidation.optOuts.test.ts:468 asserts checks(DeclarativeConnectorEntrySchema) > 01 against main, 0 here, because a pipe def has no checks array. The SPA still builds and Console Pin Gate never runs that suite, so no gate in either repo sees it. objectui resolves @objectstack/spec from the registry at ^17.0.0, so ⛔ main does not go red on merge — the break lands at objectui's next spec bump. Tracked at objectui#10211; the gate-reach gap at objectstack#19692. ⛔ A .objectui-sha bump is never a rider on another PR, so neither rides here.
  • tsc is the real sweeper. retiredKey() types the key never, so every authoring site in the monorepo fails to compile. All six affected packages typecheck green after the cleanup, which is what says the census is complete rather than the grep.

The retirement kit

  • retiredKey() tombstone on the non-strict ConnectorSchema (a bare delete would be a silent strip, ADR-0104), inherited by DeclarativeConnectorEntrySchema.
  • RETIRED_KEYS_BY_MAJOR[18] × 2 — integration/Connector:connectionTimeoutMs and integration/DeclarativeConnectorEntry:connectionTimeoutMs — as one-file-per-entry under migrations/entries/retired-keys/.
  • D2 connector-connection-timeout-ms-removed in conversions/registry.ts, wired into the step-18 chain.
  • ADR-0087 residue stage acceptRetiredDefaultResidue on both carriers with { connectionTimeoutMs: 30000 }. A D2 does not discharge this: the ruled precedent 18.security__ObjectPermission__allowPurge carries both a D2 (permission-allow-restore-purge-removed) and the residue stage, so D2 coverage cannot be the discriminator. The discriminator is whether a released toolchain MATERIALIZED the default — a 17.x toolchain emits connectionTimeoutMs: 30000 into every connector entry, authored or not — and the second door is AutomationEngine.registerConnector, which parses ConnectorSchema for a def a plugin builds in code, where no conversion runs. Without the stage a 17.x connector package fails registration on a value its author never typed. Head now accepts-and-strips 30000 while still refusing 15000, 1000 and "30000". The preprocess pipe this introduces moves five ADR-0097 refinement sites onto its OUT side, so dropped-refinements.baseline.json moves with them — exactly the moves the build gate printed, no additions.
  • D3 semantic connector-provider-context-connection-timeout-ms-retired for the withdrawn ConnectorProviderContext member — a provider factory is code, so there is no authored source for a conversion to rewrite.
  • liveness/connector.json: the row stays dead with a REMOVED note, because retiredKey() keeps the key in the walked shape (the rls.priority precedent). Its stale 「every occurrence outside packages/spec is a WRITE」 claim is corrected there, with the reads named.
  • Baselines: authorable-surface/integration.json gains two [RETIRED] rows, authorable-defaults/integration.json loses the two = 30000 rows. api-surface/ and json-schema.manifest/ are byte-identical — the correct reading for a key-only tombstone that retires no def, not a missed regeneration.
  • Consumers cleaned: the four connector packages and service-automation (fingerprint, declared-item shape, context build, degraded husk).
  • Declared widening, round 4: packages/spec/liveness/README.md's connector row asserted, present tense, that the entry schema is ConnectorSchema.superRefine(...) — and rested its byte-identical-key-set conclusion on that attachment. Both halves are corrected: the mechanism is now the pipe's read-through shape, and the conclusion is re-measured rather than inherited (30 keys each carrier, byte-identical, zero entry-only, zero base-only). ⚠️ Hand-edited on purpose, ⛔ never regenerated: .gitattributes:71-77 splits liveness/state-counts.md (driver-managed numbers) from liveness/README.md (hand-written Notes prose), because 「regenerating a Note would fabricate a verdict」.
  • ⚠️ A SECOND, declared narrowing: the ZodObject combinators leave both published exports. Wrapping ConnectorSchema and DeclarativeConnectorEntrySchema in the residue stage makes them z.preprocess pipes, so .extend(), .omit(), .pick(), .partial(), .merge(), .strict(), .keyof() and .safeExtend() no longer exist on them. Build on the object and re-wrap — acceptRetiredDefaultResidue(<the extended object>, { connectionTimeoutMs: 30000 }), the EffectiveObjectPermissionSchema route. ⚠️ .superRefine() still exists on a pipe and is callable, but returns a schema with no read-through shape — which is exactly what the schema walkers duck-test — so refine before wrapping, never after. Parsing, z.input / z.infer and the read-through .shape are unchanged. The changeset's FROM → TO carries this row; the docblock at connector.zod.ts and the superseded sentence it replaces carry it in the source.
  • Changeset Clause-②: yes (narrowing), minor on @objectstack/spec (the launch-window gate refuses major), patch on the five consumer packages, with the FROM → TO table and the ADR-0087 disposition marker.

Tests and gates run locally

run verdict
pnpm --filter @objectstack/spec build exit 0
dependency-closure build of the five consumer packages exit 0
typecheck × 6 (spec, connector-rest, connector-openapi, connector-mcp, connector-slack, service-automation) exit 0
test × 5 consumer packages 1786 passed
spec src/integration src/conversions src/migrations + the migrate-sentence and cron pins 569 passed / 16 files
spec test:repo 600 passed
full pnpm build + the re-derived 112-command gate sweep on this head 112 / 112, and on the latest round with zero prerequisite failures, because the full build ran first (earlier rounds had three first-pass non-zeros, all PREREQUISITE NOT MET from unbuilt packages ⇒ read as NOT MEASURED, ⛔ never as failures, and re-run green after the build)
the new retirement pin under --project repo 15 passed
check:generated 15 of 15 green, check:docs and check:liveness included
the 14 source audits check:generated names as not run all exit 0, each captured separately
check:nul-bytes, check:cross-package-test-inputs, check:adr-0087-registration, check:changeset-no-major exit 0

Every exit code above was captured before any pipe. The repo-wide gate farm is CI's run, not this PR's local obligation.

Acceptance notes

  • Scope deviation, declared. The dispatch fenced content/docs/** off. content/docs/references/integration/connector.mdx is an auto-generated baseline whose gate (check:docs) is inside the required TypeScript Type Check job, and it goes stale on this change alone. Measured across all 19 open PRs (283 file rows, 0 unreadable): zero hold that path, so the fence's stated reason — "open PRs hold files there" — does not apply to it; the instrument discriminates, returning content/docs rows for seven other PRs. It is regenerated here, exactly as the sibling retirement fix(spec): retire tenancy.organizationField from the authorable surface (#19054) #19618 regenerates four of the same tree's pages. No hand-written content/docs/** prose is touched, and skills/** and .claude/** are untouched — this diff hits no governed surface.
  • Scope, mechanically forced. The tombstone types the key never, so the four connector packages and service-automation must stop writing it or the monorepo does not compile. Those paths are outside the claim's declared file surface and are held by zero open PRs on the same census.
  • The two-writer surface materialised as declared — see the report.
  • packages/spec/vitest.repo-tests.json gains one line: the new tree-scoped absence pin's walk radius, which check:cross-package-test-inputs demanded by name. No new glob; the radius was already declared for this package.
  • The connectionTimeoutMs-is-never-mapped pin in connector-fetch-policy.test.ts is kept after the retirement, deliberately: it is what makes a re-introduction as a silent alias onto timeoutMs fail.
  • health.circuitBreaker remains dead on this schema and is not touched here — a different set of rows on the same ADR-0049 worklist.

Generated by Claude Code

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests tooling labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 6 package(s): @objectstack/connector-mcp, @objectstack/connector-openapi, @objectstack/connector-rest, @objectstack/connector-slack, @objectstack/service-automation, @objectstack/spec, touching 31 documentable anchor(s). ⚠️ 10 changed file(s) yielded no anchor (packages/spec/authorable-defaults/integration.json, packages/spec/authorable-surface/integration.json, packages/spec/docs/SYNC_ARCHITECTURE.md, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v15.mdx (via ConnectorSchema (symbol, a top-level const))
  • content/docs/releases/v17/17-0.mdx (via ConnectorSchema (symbol, a top-level const), DeclarativeConnectorEntrySchema (symbol, a top-level const))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 10 changed file(s) yielded no anchor (packages/spec/authorable-defaults/integration.json, packages/spec/authorable-surface/integration.json, packages/spec/docs/SYNC_ARCHITECTURE.md, …) — pages documenting those are invisible to this run
  • 8 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 60 of 215 client-bound route-ledger rows — the other 155 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 155: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 100 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 136 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 6eaa0f4a81a0146250f083df2b9d000b75dbec61packageMentionDocs.

Which tree this was computed on

This run read content/docs from 2b92990ed2f80d167a6def02a1968e5ef0e86ffd — the merge of head 1e5a44ab640141319360551b9207e711fee8fb47 into base 6eaa0f4a81a0146250f083df2b9d000b75dbec61, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 2b92990ed2f80d167a6def02a1968e5ef0e86ffd && git checkout 2b92990ed2f80d167a6def02a1968e5ef0e86ffd
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 6eaa0f4a81a0146250f083df2b9d000b75dbec61 1e5a44ab640141319360551b9207e711fee8fb47 && git checkout -B drift-repro 6eaa0f4a81a0146250f083df2b9d000b75dbec61 && git merge --no-ff 1e5a44ab640141319360551b9207e711fee8fb47

node scripts/docs-audit/affected-docs.mjs --json 6eaa0f4a81a0146250f083df2b9d000b75dbec61

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 6eaa0f4a81a0146250f083df2b9d000b75dbec61 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

…eted card number

The four #19388 citations this change added do not resolve: probed
[deleted] — minted, absent from the board, and the web endpoint 404s.
The claim they attributed is unchanged and independently checkable in the
tree, so each site now names connector-fetch-policy.ts, where
connectorFetchOptions() maps requestTimeoutMs onto resilientFetch's
per-attempt timeoutMs, pinned by connector-fetch-policy.test.ts.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
… correct the census note

F1 — the key was `.optional().default(30000)`, so a 17.x parse materialized it
into every connector. Measured across two builds: the base build emits it for an
entry that authored only name/label/type, and the tombstoned build refused that
exact object at connectors.0.connectionTimeoutMs. Adopts the ruled
acceptRetiredDefaultResidue stage on both carriers. A D2 does not discharge this
obligation — the ObjectPermission precedent carries both — because
AutomationEngine.registerConnector parses ConnectorSchema for a def a plugin
builds in code, where no conversion runs. Nothing is un-retired: z.input stays
never, the [RETIRED] row stays, and any other value keeps the refusal.

The residue wrapper is a preprocess pipe, so the ADR-0097 refinements move onto
its OUT side; dropped-refinements.baseline.json moves the five site paths with
them, as the gate required in the same change.

F2 — the card's five-writes table was CORRECT at the SHA it cited (0870fb5)
and was superseded by b929e0a. It is stale, not false, and the ledger note,
the entry and the changeset now state both readings with their trees: thirteen
non-test source occurrences over seven files in five packages at origin/main —
six reads, four type declarations, three surviving hardcoded writes.

N2 — the absence-pin pointer names the file the pin actually lives in.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
FB1 — connector.zod.ts still promised that the base export 'stays a plain
object so connector subtypes can still .extend() it'. Both published carriers
are z.preprocess pipes since the residue stage, so that is false, and the
sibling repo quotes the sentence verbatim in its own code. Measured on the
built entry against a plain-object control (WebhookConfigSchema, which keeps
all nine): .extend/.omit/.pick/.partial/.merge/.strict/.keyof/.safeExtend are
gone from both. .superRefine SURVIVES — it lives on zod's base type — but
returns a schema with no read-through shape, so my own new docblock overstated
it and is corrected too. The affordance withdrawal is now a FROM to TO row in
the changeset with the extend-the-base-and-re-wrap remedy.

FB2 — five records asserted a composition this change abolished: the two
carriers no longer derive from one another, they are siblings wrapping one
private ConnectorBaseSchema. Three of them I authored in the round that fixed
the same defect class. Corrected in the two retired-key entries, the two
conversion docblocks, the schema docblock, the reachability comment in
connector.test.ts and the liveness _note, whose walk mechanism is restated and
whose conclusion is re-measured: 30 keys on each carrier, byte-identical key
sets, no entry-only and no base-only key.

NB5 — the changeset said allowPurge carries both 'because' registerConnector,
compressing two different reasons into one. Separated.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
…s README

Declared widening, one table row. The row asserted in the present tense that
DeclarativeConnectorEntrySchema IS ConnectorSchema.superRefine(...) and rested
its byte-identical-key-set conclusion on that Zod 4 attachment. This PR
falsifies both halves: the two carriers are now siblings wrapping one private
ConnectorBaseSchema in the residue stage, and what preserves the walked shape
is the pipe's read-through shape, not a superRefine attachment.

Mechanism corrected, conclusion kept and re-measured on the built entry (30
keys each, byte-identical, zero entry-only, zero base-only), and the row says
which spelling moved and when — the form used on the six sibling sites. This
file is hand-written Notes prose by .gitattributes' own split, not a driver-
managed artifact, so a hand correction is the right act; regenerating a Note
would fabricate a verdict.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
…head

FB-A — forty words after the sentence round 4 corrected, the row still said
'four retiredKey tombstones'. Two instruments disagreed on the absolute number
and agreed on the delta, so I established the scope the sentence means before
counting: it enumerates the contents of THIS ledger's dead set, so the
population is this file's dead rows that are retiredKey tombstones kept because
the key stays in the walked shape. One instrument over both refs reads 5 on
origin/main and 6 at head. The six are now named individually rather than
totalled, with the double-count that made the old tail drift called out: three
of them already sit inside the fieldMappings, triggers and health counts.

NB-1 — the rest of the row was stale too (not introduced here; byte-identical
on origin/main). The 20/1/53 split and the 53 dead become 29/1/44 and 44, cited
to the generated state-counts row. retryConfig (8) leaves the dead list
entirely: all eight sub-keys are live since #18975, which is the same
measurement this row's own falsification note records. 'The two timeouts' is
corrected: requestTimeoutMs is live, connectionTimeoutMs is the tombstone. The
decomposition is partitioned so every dead row is counted once and sums to 44.

NB-2 — the four PR-authored 'inherits' spellings contradicted this PR's own
'siblings, not parent and child'. Respelled the way connector.zod.ts already
does. The pre-existing ones are left for their own round.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
…its census stale

Found by doing what the round asked — re-reading the WHOLE row against head
rather than the named sentences. The closing note asserted two things that are
no longer true, and one of them contradicted the correction this same round
made forty words earlier:

- it recorded retryConfig's 'they are live' claim as falsified, but #18975 made
  the declared policy execute at the one platform fetch site, so those eight
  sub-keys are live now and the claim came true after the fact;
- its supporting census, 'the word does not occur outside packages/spec at
  all', is false at this head: git grep over the tree minus packages/spec
  returns 54 hits over 10 files.

Both halves are recorded rather than overwritten — the history of how the type
got here is what this row is for — and the census is restated with the command
and the tree behind it.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
…d command

The census clause printed 54 hits over 10 files while printing a command
that returns 67 over 15: the reading was taken with `.changeset` excluded
and the exclusion was never written down, and the parenthetical covered
neither of the two `content/docs` pages it returns. Print the command that
produces the number, pinned to the tree it was taken against, and make the
parenthetical account for all fifteen files.

Same row: `name` is itself a `ConnectorProviderContext` field, so the
"plus `name`" tail double-counted it, while `provider` -- which selects the
factory and never reaches the context -- sat outside the "exactly".
`loadPackageFile` is host-injected rather than authored. Correct the set.

Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
Co-authored-by: Claude <noreply@anthropic.com>
…on claims

The `_note` in `packages/spec/liveness/connector.json` still carried the
uncorrected form of the key-reach claim after the README row was fixed, and
its tail asserted something the same file's own `actions.key` row already
contradicted. Four measured corrections, all in one sentence:

  1. `name` IS a `ConnectorProviderContext` field
     (`connector-provider.ts:68`), so "plus `name`" double-counted it;
  2. `provider` is read on the AUTHORING door and is not on the interface —
     `plugin.ts:1478` gates the desired set on it and `:1533` selects the
     factory via `engine.getConnectorProvider(provider)` — so it was left
     out of the "exactly";
  3. `loadPackageFile` IS a context field (`:117`) that no authored key
     reaches — `plugin.ts:1601` injects `createPackageFileLoader(...)` — so
     it was over-included;
  4. "read by no runtime" is FALSE: `plugin.ts:433`
     `findInertDeclaredConnectors` reads `(c.actions?.length ?? 0) > 0` on
     every descriptor at boot, which the `actions.key` row already records
     as the #2612 inert-descriptor warning. Reaching no provider factory
     and being read by nothing are two different claims; only the first
     holds of the remainder.

The whole entry-read census is now stated: the materializer reads exactly
`name`, `provider`, `enabled`, `label`, `description`, `icon`, `type`,
`providerConfig`, `auth`, `retryConfig`, `requestTimeoutMs` plus that one
`actions` read, the last nine also being `connectorInstanceSignature`.

README row 942, `authentication` clause: "refused outright by ADR-0097 §3"
is contradicted by all three instruments including the one it cites. The
key is accepted (`connector.zod.ts:893`
`.optional().default({ type: 'none' })`); `:1168` refuses a non-`none`
VALUE and `:1174`'s message prescribes "drop `authentication` (or set
`{ type: 'none' }`)"; ADR-0097 §3 "Credentials are references" rejects
INLINE SECRETS, not the key. Accepted-and-ignored plus a loud refusal of
every other value is the basis of the `planned` verdict the row already
stated.

Same file, `auth` row: "whose other half (`authentication`) is refused"
compressed to the same wrong claim; scoped to "any value but
`{ type: 'none' }`".

README row 942, census sentence: "67 hits" -> "67 matching lines", with the
`git grep -o` reading (77 occurrences) beside it — re-measured at
14fdebd on this checkout, 67 lines / 15 files / 77 occurrences.

Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
Co-authored-by: Claude <noreply@anthropic.com>
…tire-connector-connection-timeout

Conflict in packages/spec/src/migrations/registry.ts, step18.rationale (the
hand-written tail, outside the generated markers): main's paragraph for the
translation bundle split is kept whole after the shared closing line, and this
branch's connector.connectionTimeoutMs paragraph is appended after it. The
only byte changed in main's paragraph is its terminator (`.",` becomes `. "`)
so the concatenation continues. conversionIds merged as a set without
conflict: both ids present.

Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
Co-authored-by: Claude <noreply@anthropic.com>
…tire-connector-connection-timeout

Second sync: main advanced by six commits after the first merge, including
the tenancy.organizationField retirement, which also appends to
step18.rationale. Conflict in packages/spec/src/migrations/registry.ts,
step18.rationale (hand-written, outside the generated markers): the shared
closing line and the translation bundle paragraph stay once, the
organizationField paragraph is kept whole, and this branch's
connector.connectionTimeoutMs paragraph is appended after it. The only byte
changed in main's text is the organizationField paragraph's terminator
(`.',` becomes `. '`) so the concatenation continues. conversionIds merged as
a set without conflict: all three step-18 additions present.

Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 1e5a44ab640141319360551b9207e711fee8fb47

Reviewed and posted 2026-09-23T11:03Z by the at-tier review subagent the domain:spec#5 seat spawned — read: card #19580 (all 38 comments; reports treated as claims), the PR body/commits/check-runs, the 31-file diff against merge-base 6eaa0f4a81, AGENTS.md, contract-review.md, the spec-property-retirement skill; ran, in a sibling worktree at the head: safeParse / conversion / registry probes on the head tree and on the pre-retirement base tree, the retirement pin under --project repo (15/15), the migrate-sentence pin (14/14), the connector + conversions + migrations suites (516/516), and the sweeps below; NOT MEASURED: the objectui SPA build against this head (no Console Pin Gate run exists at this head) and the derived gate family (read from CI, never re-run).

① Derived judgments

  • Applied nowhere — confirmed first-hand. At merge-base 6eaa0f4a81, git grep connectionTimeoutMs over non-spec, non-test code files: 13 occurrences / 7 files / 5 packages — 6 reads (plugin.ts:307 fingerprint, :1589 context build, rest-provider.ts:64 + openapi-provider.ts:193 ctx. pass-throughs, rest-connector.ts:134 + openapi-connector.ts:242 ?? 30000 onto the def), 4 type declarations, 3 literal writes. Every read terminates on the echoed def or the fingerprint; connectorFetchOptions() reads { retryConfig, requestTimeoutMs } only (control: requestTimeoutMs resolves to opts.timeoutMs, 22 non-spec code lines). At the card's 0870fb5418: exactly the five literal writes. objectui at .objectui-sha 87af769e9a3e…: 0 hits (exit 1); control DeclarativeConnectorEntrySchema 12 hits; no .extend/.omit/.pick/.partial/.merge/.strict/.keyof/.safeExtend/.superRefine/.shape call on either connector schema there. At head, no authoring survives outside the kit (tree-scoped pin green in my worktree; hand grep agrees — remaining hits are comments, prose and the pins).
  • What an author gets (ran, head). ConnectorSchema, DeclarativeConnectorEntrySchema, getMetadataTypeSchema('connector') and ObjectStackSchema each refuse 15000, 1000 and "30000" with code: invalid_type, path: ['connectionTimeoutMs'] (stack: connectors.0.connectionTimeoutMs) and the full prescription — fully-qualified key, removed in @objectstack/spec 17 (ADR-0049 …), names requestTimeoutMs, ends with the os migrate meta --from 17 sentence. 30000 is accepted and stripped on both carriers. Negative controls: the same objects without the key parse; an unknown key is stripped silently (non-strict, unchanged); requestTimeoutMs: 'x' fails at its own path. Base-tree control: the pre-retirement schema emits connectionTimeoutMs: 30000 for an entry authoring only name/label/type, and the write door retained 4321 — so the residue stage and the D2 are both owed, as the PR says. tsc channel: z.input is never (pin with @ts-expect-error green).
  • Registration. RETIRED_KEYS_BY_MAJOR[18] holds integration/Connector:connectionTimeoutMs and integration/DeclarativeConnectorEntry:connectionTimeoutMs once each, no other major. D2 connector-connection-timeout-ms-removed: toMajor: 18, retiredFromLoadPath: true, fixture disjoint, one attributed notice at connectors[0].connectionTimeoutMs, replay idempotent (0 notices, same reference), silent on the default load path, and applyConversionsToStoredItem('connector', …) strips the key with requestTimeoutMs intact. D3 connector-provider-context-connection-timeout-ms-retired present in step 18 with non-empty reason / acceptanceCriteria naming requestTimeoutMs. RETIRED_DEFS_BY_MAJOR[18] untouched (only the pre-existing integration/ConnectorErrorCategory).
  • step18.rationale after two conflict resolutions — whole and once. All 86 of main's rationale lines appear in head byte-exact and exactly once, except main's last line whose closing quote-comma becomes a trailing space inside the string (the same edit fix(spec): retire tenancy.organizationField from the authorable surface (#19054) #19618 made to feat(spec)!: split the translation bundle type — settings is a platform group, not a per-app one (#15178) #19600's line); the feat(spec)!: split the translation bundle type — settings is a platform group, not a per-app one (#15178) #19600, fix(spec): retire tenancy.organizationField from the authorable surface (#19054) #19618 and this PR's paragraph heads each occur exactly once; exactly one quote-comma terminator; conversionIds = main's 33 in main's order plus connector-connection-timeout-ms-removed, no duplicates. The semantic[] and RETIRED_KEYS_BY_MAJOR regions differ from main only by this PR's entries.
  • Liveness ledger. Row stays dead, verifiedAt 2026-09-22, REMOVED note — correct for the tombstone route. README connector row: the 44-dead partition re-summed from connector.json (syncConfig 8, fieldMappings 7, health 15, triggers 6, webhooks 1, status 1, metadata 1, actions 2, three top-level tombstones 3 = 44); six tombstone rows by name; state-counts.md row 29/1/44 (unchanged, consistent). _note claims re-derived at head: fingerprint hashes exactly nine keys (has provider, no enabled); authentication declared .optional().default({ type: 'none' }) at :893, non-none value refused at :1168; the connector-rate-limit-config-removed fixture comment (:4503) and the field-mapping-transform-removed "Execution: none" line (:4544) are quoted as they read; ConnectorTrigger docblock verbatim; retryConfig at 14fdebd766 = 67 lines / 77 occurrences / 15 files; syncConfig outside spec = two comment lines in the dogfood ledger; objectui dda8f3815 previews = 22 distinct types / 20 components, connector absent; both carriers expose 30 identical keys. One overtaken count — non-blocking (iv).
  • Baselines and docs. authorable-surface/integration.json +2 [RETIRED]; authorable-defaults/integration.json −2 = 30000; api-surface/ and json-schema.manifest/ untouched — correct for a key-only tombstone (api-surface records ConnectorSchema (const) by name only); dropped-refinements.baseline.json moves exactly the 5 connector sites onto .out. content/docs/references/integration/connector.mdx is AUTO-GEN and mirrors the docblock; its currency rests on check:docs inside the green required TypeScript Type Check job (not re-run here). No hand-written content/docs, skills/, examples/, *.form.ts or i18n surface carries the key; packages/lint and packages/qa/dogfood have no row to move.
  • Console Pin Gate. Not affected by reading: objectui imports the two schemas only to safeParse. The SPA build against this head is NOT MEASURED (the gate was skipped, see CI). The sibling break is a structural test assertion, optOuts.test.ts:468 checks(DeclarativeConnectorEntrySchema): 1 on the base tree, 0 at head (both measured); objectui#10211 open, AGENTS.md §4 promises the pinned sibling is protected, but Console Pin Gate only BUILDS it — a break that reds objectui's tests is invisible to every gate in both repos #19692 closed not_planned.
  • Shipping-sentence sweep (normalised: */// stripped, backticks dropped, ' + ' seams joined). Verified: the thirteen/seven/five census and the five-writes census with their trees; the nine siblings (8 retryConfig + requestTimeoutMs); allowPurge carries D2 (:8595) and the residue stage (permission.zod.ts:563, the EffectiveObjectPermissionSchema route at :595); the two non-residue siblings are registered keys; combinators: eight gone on both carriers, superRefine survives and returns a schema with no shape (all measured against a plain-object control that keeps all nine); Clause-②: yes (narrowing) (the ruling wrote no; the claim corrected it to yes, which is what AGENTS.md's closed pair requires for a removal). Flagged — all non-blocking: (i) changeset: "a published interface member leaves ConnectorProviderContext" — the member entered with b929e0a662 (2026-09-20), after the last tag @objectstack/*@17.4.0 (2026-09-09; npm latest 17.4.0), so no release ever carried it; same for RestConnectorOptions.connectionTimeoutMs / OpenApiConnectorConfig.connectionTimeoutMs. (ii) "five sites … READ" (schema docblock, conversion docblock, pin header, rationale) vs "six reads" (changeset, entry, ledger row, PR body) — same set, the two ?? 30000 fallbacks counted as one site or two. (iii) changeset + entry: "the tombstoned build refuses that exact object at connectors.0.connectionTimeoutMs" — head accepts-and-strips it (residue stage); true only of the tombstone without the stage. (iv) ledger _note: "fieldMappings occurring on 14 lines over 6 files outside packages/spec" cites no tree; 14/6 at 9e2843a4d3, 15/7 at head after main's b22e3f7646 added skills/objectstack-upgrade/evals/protocol-major-upgrade.json (the gloss "prose, no read" still holds). (v) PR body: "objectui resolves @objectstack/spec from the registry at ^17.0.0, so main does not go red on merge" — the gate injects the local spec dist (OBJECTSTACK_SPEC_DIST); the real reasons are that the gate only builds (tsc && vite build) and its path filter does not fire on this diff. Not re-measured (historical censuses): the 19-open-PR / 283-row file census and the local gate tallies. Model identifiers: swept for every model-identifier spelling over the diff, the changeset, the PR body and all 19 commit messages — zero hits; control file 2 hits; commit trailers are the model-free pair.
  • CI at the head (35 check-runs, 35 distinct names, de-dup needed none; latest started_at 2026-09-23T08:38Z): 33 success, 2 skipped, 0 failure. Skips: Console Pin Gateneeds.filter.outputs.console == 'false' (its paths are .objectui-sha, the five console scripts and ci.yml; none in the diff); Packed-tarball smoke (opt-in) — opt-in label needs:pack-smoke absent. Check Changeset (runs check-changeset-no-major and check-adr-0087-registration), Spec property liveness, Lint & Repo Gates and TypeScript Type Check all green. mergeable_state: clean.

② Semver level

Correct. @objectstack/spec: minor (the launch-window gate refuses major; Check Changeset green) carrying the BREAKING banner, the FROM → TO table and the one-line fix, Clause-②: yes (narrowing), and exactly one ADR-0087 marker <!-- adr-0087: registered connector-connection-timeout-ms-removed, connector-provider-context-connection-timeout-ms-retired --> — both ids exist in the registries. patch on connector-rest, connector-openapi, connector-mcp, connector-slack, service-automation is defensible: nothing those packages published is removed (the option fields are post-17.4.0), and the one observable change — the def GET /connectors echoes no longer carries connectionTimeoutMs — is declared in the changeset.

③ Boundary flags

Dev flags, each answered on the card: content/docs/references/…/connector.mdx regenerated outside the fence (AUTO-GEN per the Documentation Guardrails; releases/ untouched) — accepted; the five consumer packages forced by tsc — accepted; the vitest.repo-tests.json line demanded by check:cross-package-test-inputs — accepted, and the pin's radius is declared (turbo @objectstack/spec#test:repo inputs carry packages/** by extension, examples/** non-code, content/**, skills/**, scripts/** — exactly the pin's roots and extension sets); dropped-refinements.baseline.json — accepted; README widening — accepted; PR-body edits deferred to the seat — present at head. Round-6 open question (two pending fragments) → option A, #19729 — closed via #19746, which is in this head. open_questions: [] on the merge-round report; the two merges verified above.

Blocking: none.
Non-blocking:

  1. ⚠️ Escalate before changeset version — unnamed by any round: .changeset/18975-connector-retry-config-and-request-timeout.md (pending, @objectstack/spec: minor) will publish into the same 17.5.0 CHANGELOG entry as this changeset the sentences "ConnectorProviderContext gains retryConfig, connectionTimeoutMs and requestTimeoutMs" and "connectionTimeoutMs … is carried onto ConnectorProviderContext (a custom provider … may honour it)". Unlike Two PENDING changesets ship false connector-ledger mechanism claims into CHANGELOG.md — and they are two different classes, only one of which may be corrected #19729's class 2, that state is never released, so the entry would describe a member 17.5.0 does not have while this entry says it was removed. Outside this diff by the seat's own Two PENDING changesets ship false connector-ledger mechanism claims into CHANGELOG.md — and they are two different classes, only one of which may be corrected #19729 rule; needs the docs(changeset): correct two false mechanism claims in a pending connector-ledger note #19746 route (docs-only correction, maintainer countersign) or an explicit seat authorisation to absorb those two clauses here. Seat's call.
  2. Changeset wording (i): say the ConnectorProviderContext member and the two options fields were added after 17.4.0 and never published; the Clause-② sentence should rest on the authorable key alone. Wording (iii): "the tombstone without the stage refuses …". Count (ii): pick "six reads" or "five sites" once, tree-wide.
  3. Ledger _note (iv): add the tree (9e2843a4d3) or re-cite 15 lines / 7 files at head — the row's own lesson.
  4. The merge-round report's "to file (a)" finding (check:type-check-debt --re-measure spawns an unlocked whole-repo turbo build that clobbers dist under os-verify-lock) has no card — only check:type-check-debt --re-measure trusts stale dist/: phantom upward drift for ledgered packages whose deps resolve to build artifacts, unless the caller builds the closure first #8271 (closed, a different defect). Seat to file.
  5. objectui#10211 (open) is the pin-bump-time break; no bump rides here, per the standing rule.

Implemented-by: claude/issue-19580-retire-connector-connection-timeout
Reviewed-by: session_01Sfe5YjBLwB9J3y8fvm2xq1 — at-tier review subagent spawned by the domain:spec#5 seat

VERDICT: PASS

@os-justin
os-justin marked this pull request as ready for review September 23, 2026 11:04
@os-justin
os-justin enabled auto-merge September 23, 2026 11:04
@os-justin
os-justin added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit fc29c74 Sep 23, 2026
40 checks passed
@os-justin
os-justin deleted the claude/issue-19580-retire-connector-connection-timeout branch September 23, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xl tests tooling

Projects

None yet

3 participants